Extend the support range for the no_proxy variable
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jeremie-stripe! The tests didn't make it, maybe the file wasn't added to Git (seeing the tsconfig.json change)? |
|
🤦 , sorry about that, added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from microsoft/vscode#206622
Add wider support for the possible values that can be in
no_proxy(both with values provide via configuration like a vscode setting and from the process environment variable).Since there is no one true way to process the content of the
no_proxyvalue, I tried to follow the most compatible approach as outlined in https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/. See also the man pages of tools likecurlorwgetfor examples.The PR supports the following options:
*Tests were added.