Skip to content

Test: GitHub PR Extension 0.7.0 #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
meaghanlewis opened this issue May 13, 2019 · 0 comments
Closed
5 tasks done

Test: GitHub PR Extension 0.7.0 #1152

meaghanlewis opened this issue May 13, 2019 · 0 comments

Comments

@meaghanlewis
Copy link
Member

meaghanlewis commented May 13, 2019

This iteration, @queerviolet introduced React in the PR overview page. (#1096). For testing we should confirm the PR overview page still behaves as expected. This includes:

  • The header and details view displaying correctly
  • Correct ordering of commits and other timeline events
  • Diffs are able to be opened and render correctly
  • Commenting still works as expected including creating a new comment, editing, and deleting comments
  • For a PR, can switch between review mode seamlessly

Please test against the nightly version of the extension, which should have the most recent changes:
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github-insiders

And file issues in this repo: https://github.com/Microsoft/vscode-pull-request-github

You can use https://github.com/auchenberg/pullrequest-demo for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants