Skip to content

Suggested description page styling tweaks #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RMacfarlane opened this issue May 15, 2019 · 9 comments
Closed

Suggested description page styling tweaks #1156

RMacfarlane opened this issue May 15, 2019 · 9 comments

Comments

@RMacfarlane
Copy link
Contributor

Found while testing #1152

  • While the page is loading, the text "Loading..." is displayed at the very top of the page with no padding. It would be nice to have a top margin for this, or possibly make it more central
  • The comment editor seems to have lost its padding between the text area and buttons:

Screen Shot 2019-05-14 at 11 03 57 AM

@Ashniu123
Copy link

Can I try this?

@RMacfarlane
Copy link
Contributor Author

@Adam13531 Yes! The second bullet point has already been fixed. The code that adds the "Loading..." text is here:

return pr ? children(pr) : 'Loading...';
and the stylesheet is preview-src/index.css

@Adam13531
Copy link
Contributor

@Adam13531 Yes!

I think you may have tagged the wrong person. @Ashniu123, see the last response.

@Ashniu123
Copy link

Should I just put an margin-top like

<div margin-top="10px">Loading...</div>

? Or Add use the "title" class ?

@JeffreyCA
Copy link
Member

It would be helpful to post some screenshots so we can visually compare the two

@marcuslyons
Copy link

Would something like this work, or is this too far?

Before - no spacing:

before-spacing-change

After - centered:

after-spacing-changes

@RishabhKothaari
Copy link
Contributor

@queerviolet
if this is still open and available? I would like to take it. I have centered the "Loading..." text and increased the font size so that it is more visible.

#1156

@Ashniu123
Copy link

Ashniu123 commented May 23, 2020

@rishab-pdx if your PR is ready then by all means... Go ahead! :D

Edit: I'd recommend to not increase the font-size unnecessarily as people generally set their font sizes to suite them and overriding it would be bad UX.

@RishabhKothaari
Copy link
Contributor

@Ashniu123 that makes sense. Here is the final view.

#1156

Let me know what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants