Skip to content

Pull requests created from a fork on a topic branch aren't discovered. #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexr00 opened this issue May 3, 2022 · 4 comments · Fixed by #3512 or #3580
Closed

Pull requests created from a fork on a topic branch aren't discovered. #3511

alexr00 opened this issue May 3, 2022 · 4 comments · Fixed by #3512 or #3580
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented May 3, 2022

  1. Create a fork of a repo
  2. Clone your fork. Configure your remotes so that your fork is origin and the upstream repo is upstream.
  3. Checkout a topic branch in your fork
  4. Commit some changes
  5. Make a pull request back to the original repo that you forked from. (if the upstream repo doesn't show in the PR view, make sure that you have githubPullRequest.remotes configured correctly).
  6. Remove GHPRI's knowledge of your PR (can delete the github-pr-owner-number from your git config and reload or create a Codespace from the PR).
  7. 🐛 The "Pull Request" view will not show. GHPRI is not able to tell that the current branch is associated with a PR.
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label May 3, 2022
@alexr00 alexr00 added this to the May 2022 milestone May 3, 2022
@alexr00 alexr00 self-assigned this May 3, 2022
@aeschli
Copy link
Contributor

aeschli commented May 31, 2022

Testing with
[email protected]

After I deleted the the key from git config I reloaded the Window.

The status bar would only show the branch name, but not the PR number. Is that expected or is that what should have been fixed? @alexr00

@alexr00
Copy link
Member Author

alexr00 commented May 31, 2022

That's what should have been fixed. The PR is still open?

@aeschli
Copy link
Contributor

aeschli commented Jun 1, 2022

I've closed the PR in the meantime as it was in a public repo and I didn't want to confuse.
Let me know if I should set it up again.

@alexr00 alexr00 reopened this Jun 1, 2022
@alexr00
Copy link
Member Author

alexr00 commented Jun 1, 2022

I can repro, no need to set it up again yet.

alexr00 added a commit that referenced this issue Jun 1, 2022
instead of comparing owner and name. Comparing the name is incorrect as forks can have different names from the original.
Fixes #3511
alexr00 added a commit that referenced this issue Jun 1, 2022
instead of comparing owner and name. Comparing the name is incorrect as forks can have different names from the original.
Fixes #3511
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 3, 2022
joyceerhl added a commit to joyceerhl/test-pr-templates that referenced this issue Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
3 participants