Pull Request Detail GitHub Enterprise Avatars #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holder if it does not
StanleyGoldman
changed the title
|
|
StanleyGoldman
changed the title
queerviolet
suggested changes
Apr 19, 2019
| margin-right: 0; | ||
| } | ||
|
|
||
| body img.avatar { | ||
| body img.avatar, | ||
| body span.avatar-icon svg { |
There was a problem hiding this comment.
Did we decide to use a conditional filter: invert(100%); rule here, to get the default avatar icon to align with the theme?
|
I can make that change, actually. Thanks for DI'ing the change :) |
queerviolet
approved these changes
Apr 19, 2019
13 tasks
RMacfarlane
reviewed
May 3, 2019
| this._repositoryReturnsAvatar = true; | ||
| } | ||
|
|
||
| this._repositoryReturnsAvatar = false; |
There was a problem hiding this comment.
@StanleyGoldman I think we're missing an else here, or a return in the 200 check
There was a problem hiding this comment.
Thanks, I'll send a PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #416
This pull request merged the work from #1121 into #1096 and builds upon it
This corrects the display of user avatars on GitHub Enterprise in a Pull Request Detail
Depends on
https://github.com/Microsoft/vscode-pull-request-github/blob/1fa13ebb1bc50e946c27d55aec12c6ac90add710/preview-src/user.tsx#L5-L8