Guard PR data #1127
Merged
Guard PR data #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
suggested changes
Apr 19, 2019
| @@ -221,6 +221,13 @@ export class GitHubRepository implements IGitHubRepository, vscode.Disposable { | |||
| }); | |||
|
|
|||
| const hasMorePages = !!result.headers.link && result.headers.link.indexOf('rel="next"') > -1; | |||
| if (!result.data) { | |||
There was a problem hiding this comment.
It feels like a nit pick, but since this is a scenario we can't identify, i think we should log a warning and leave a comment in the code stating why, link to the issue or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the error seen by users in #574. I don't know that it'll address the underlying problem, which is that
resultshould always return data, but perhaps it'll stop masking it.