Fix spawn args (#489)

Fix fail to generate ctags when there is a space in the path. like #44 #146.

We don't need to handle space in the path when the path is passed to child_process.spawn as 'args' (not as the command).

Author: graycarl

src/client/workspaceSymbols/generator.ts

@@ -33,11 +33,10 @@ export class Generator implements vscode.Disposable {
         return await this.generateTags({ directory: this.workspaceFolder.fsPath });
     }
     private buildCmdArgs(): string[] {
-        const optionsFile = this.optionsFile.indexOf(' ') > 0 ? `"${this.optionsFile}"` : this.optionsFile;
         const exclusions = this.pythonSettings.workspaceSymbols.exclusionPatterns;
         const excludes = exclusions.length === 0 ? [] : exclusions.map(pattern => `--exclude=${pattern}`);
 
-        return [`--options=${optionsFile}`, '--languages=Python'].concat(excludes);
+        return [`--options=${this.optionsFile}`, '--languages=Python'].concat(excludes);
     }
     @captureTelemetry(WORKSPACE_SYMBOLS_BUILD)
     private generateTags(source: { directory?: string, file?: string }): Promise<void> {
@@ -57,8 +56,7 @@ export class Generator implements vscode.Disposable {
         if (!fs.existsSync(outputDir)) {
             fs.mkdirSync(outputDir);
         }
-        outputFile = outputFile.indexOf(' ') > 0 ? `"${outputFile}"` : outputFile;
-        args.push(`-o ${outputFile}`, '.');
+        args.push('-o', outputFile, '.');
         this.output.appendLine(`${'-'.repeat(10)}Generating Tags${'-'.repeat(10)}`);
         this.output.appendLine(`${cmd} ${args.join(' ')}`);
         const promise = new Promise<void>((resolve, reject) => {