Skip to content

ctag generate problem #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Nov 14, 2017 · 4 comments
Closed

ctag generate problem #146

DonJayamanne opened this issue Nov 14, 2017 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

From @MarekLew on July 18, 2017 7:55

Environment data

VS Code version: 1.14.1
Python Extension version: 0.6.7
Python Version: 2.7.13
OS and version: Microsoft Windows 10 Home ,10.0.15063 Compile 15063
ctag Version:
Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert
Compiled: Jul 9 2009, 17:05:35
Addresses: [email protected], http://ctags.sourceforge.net
Optional compiled features: +win32, +regex, +internal-sort

Actual behavior

ctag not generate when optionsFile have space

Expected behavior

generate ctag when path have space

Steps to reproduce:

  • generate ctag Python: Build Workspace symbols
  • return in console
    ctags.exe: cannot open option file ""C:\Users\User with space\.vscode\extensions\donjayamanne.python-0.6.7\resources\ctagOptions"" : Invalid argument

Settings

Your launch.json (if dealing with debugger issues):

Your settings.json:

Logs

Output from Python output panel

 ctags.exe: cannot open option file ""C:\Users\User with space\.vscode\extensions\donjayamanne.python-0.6.7\resources\ctagOptions"" : Invalid argument

Output from Console window (Help->Developer Tools menu)

In this moment I replace

@generator.js line 29
- const optionsFile = this.optionsFile.indexOf(' ') > 0 ? `"${this.optionsFile}"` : this.optionsFile;
+ const optionsFile = this.optionsFile;

and its work fine, ctag generated.

Copied from original issue: DonJayamanne/pythonVSCode#1097

@DonJayamanne
Copy link
Author

From @MarekLew on July 24, 2017 10:13

In my computers on windows 10 child_process.spawn work correct without adding quotes to path with space

@DonJayamanne
Copy link
Author

From @MarekLew on July 24, 2017 20:23

VS Code version: 1.14.2
Python Extension version: 0.6.9
Python Version: 2.7.12
OS and version: Ubuntu 14.04 LTS
ctag Version: Exuberant Ctags 5.9~svn20110310, Copyright (C) 1996-2009 Darren Hiebert
  Addresses: <[email protected]>, http://ctags.sourceforge.net
  Optional compiled features: +wildcards, +regex

After delete quotes ctags generated but not sorted.

sort: cannot read: space/.vscode/tags: No such file or directory
ctags: cannot sort tag file : No such file or directory

@DonJayamanne
Copy link
Author

From @MarekLew on September 23, 2017 12:30

Version 1.16.1
Python Extension version: 0.6.7
OS and version: Ubuntu 14.04 LTS

the same problem.

End DonJayamanne#1213 don`t fixed this.

@brettcannon brettcannon added awaiting 2-PR bug Issue identified by VS Code Team member as probable bug labels Nov 14, 2017
@brettcannon
Copy link
Member

Closing as a duplicate of #44

DonJayamanne pushed a commit that referenced this issue Jan 4, 2018
Fix fail to generate ctags when there is a space in the path. like #44 #146.

We don't need to handle space in the path when the path is passed to child_process.spawn as 'args' (not as the command).
@DonJayamanne DonJayamanne added this to the January 2018 milestone Jan 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants