Rename symbol misses symbols in formatted strings f"{foo}"

[DonJayamanne]

From @sdwarwick on September 25, 2017 13:25

Environment data

VS Code version: 1.16.1
Python Extension version: 0.7.0
Python Version: 3.6
OS and version: windows 10

Actual behavior

rename/refactor symbols completely misses symbols inside formatted text strings
f"{name}"

name is not found or changed

Expected behavior

clear from above

Steps to reproduce:

Logs

Output from Python output panel

no output

Output from Console window (Help->Developer Tools menu)

no output

Copied from original issue: DonJayamanne/pythonVSCode#1237

[DonJayamanne]

From @kodalipraveen on October 13, 2017 19:16

This issue is also seen in Mac OS
VSCode - 1.17.1
Python Extension - 0.7.0

[MikhailArkhipov]

Same as #344, specifically davidhalter/jedi#930

[MikhailArkhipov]

#1418, Jedi 0.12

[brettcannon]

This is actually still failing for me. If I have:

thing = 42
print(f'hello, {thing}')

and I attempt a Rename Symbol on thing, it misses the f-string.

[FlavioCestari]

Waiting for this fix too. :)

[brettcannon]

@FlavioCestari this is going to require an upstream fix from rope.

[FlavioCestari]

It looks like the project is kind of stopped. The last release was in August, 2017.
https://github.com/python-rope/rope/releases

Is there any alternative?

[brettcannon]

Not at the moment. We are hoping to get our new analysis engine to handle refactorings/renamings.

[ikariwing]

FYI (Info from @legnaleurc): @orn688 already wrote a PR for rope to improve the symbol replacement in f-string , that PR is still not merged though. Thanks @orn688 :)

[DonJayamanne]

Closing, as this has been resolved upstream in rope.