Skip to content

function parameter hover card does not close when using IntelliSense within it #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Dec 30, 2017 · 7 comments
Closed
Labels
area-editor-* User-facing catch-all area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug

Comments

@ghost
Copy link

ghost commented Dec 30, 2017

Environment data

VS Code version: 1.19.1(1.19.1)
Python Extension version: 0.9.1
Python Version: 3.6.3
OS and version: macOS High Sierra 10.13.2(17C88)

Actual behavior

  1. key stroke "print(" -> function popup start
  2. key stroke ")" -> function popup close, but...
  3. key stoke "alt+enter" -> function popup not close

Expected behavior

  1. key stoke "alt+enter" -> function popup close

Steps to reproduce:

  1. key stroke "print(" -> function popup start
  2. key stroke ")" -> function popup close
  3. key stoke "alt+enter" -> function popup close

Logs

Output from Python output panel

Output from Console window (Help->Developer Tools menu)

@brettcannon
Copy link
Member

I think this is a VS Code issue and not us since we don't forcibly create the pop-up, just populate it when VS Code requests that we do.

@ghost
Copy link
Author

ghost commented Jan 17, 2018

Hi brettcannon.
Today I got vscode's comment. here
microsoft/vscode#41591

sorry my english. i'm korean. i use Python with Python Extension and Sublime keybinding.
If i press ( vscode automatically make ) too.
So when I input arguments and want move next line, without pressing ) + Enter, I just press Command+Enter
I aleady work next line, but function popup keep going.
reference screenshot image
https://imgur.com/a5ffQcV

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. Happy Coding!

Ok, please file this issue then against the Phyton Extension because that determines when to close the pop up.

@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. awaiting 1-verification and removed closed-upstream labels Jan 17, 2018
@brettcannon
Copy link
Member

I've re-opened this.

@brettcannon brettcannon reopened this Jan 17, 2018
@ericsnowcurrently ericsnowcurrently self-assigned this Jan 18, 2018
@ericsnowcurrently
Copy link

ericsnowcurrently commented Jan 18, 2018

I've been able to reproduce similar broken behavior (on linux) with the following:

print(f'')
range()

(The popup switches back to "function print ...".)

Whereas the following does not have the problem:

print('')
range()

So I expect that the problem is with some contextual information that the python extension is sending to VSC.

Also, I have the problem the same with and without alt+enter.

@MikhailArkhipov
Copy link

#187 - Jedi does not understand f-strings

@ericsnowcurrently
Copy link

Right. It was just a simple alternative repro of the problem, in hopes that it points to the problem. :)

@MikhailArkhipov MikhailArkhipov removed their assignment Feb 12, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Apr 5, 2018
@brettcannon brettcannon changed the title function popup bug report function parameter hover card does not close when using IntelliSense within it Apr 19, 2018
@brettcannon brettcannon added this to the June 2018 milestone Jun 5, 2018
@MikhailArkhipov MikhailArkhipov removed their assignment Oct 8, 2018
@MikhailArkhipov MikhailArkhipov removed this from the June 2018 milestone Oct 8, 2018
@gramster gramster added the area-editor-* User-facing catch-all label Oct 10, 2019
@brettcannon
Copy link
Member

This seems to have been fixed. If we are wrong then please let us know.

@ghost ghost removed the needs PR label Nov 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants