Skip to content

Create TypeScript tests between Python code and VS Code #21394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eleanorjboyd opened this issue Jun 9, 2023 · 0 comments · Fixed by #21457
Closed

Create TypeScript tests between Python code and VS Code #21394

eleanorjboyd opened this issue Jun 9, 2023 · 0 comments · Fixed by #21457
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@eleanorjboyd
Copy link
Member

eleanorjboyd commented Jun 9, 2023

This is a larger issue that will encompass writing all tests for the typescript code that is currently untested following the reconfiguration with dynamic run. All changes will be merged into a feature branch before merging the entire set of changes into main, this is because the dynamic run result changes are not yet live and these tests specifically handle the refactoring there. The following are what tests minimally we expect to write:

Files:

  • pytestDiscoveryAdapter
    • suite name: pytest test discovery adapter
    • new tests
      • discovery should call exec with correct basic args
      • discovery should pull from setting to get pytest args
  • pytestExecutionAdapter
    • suite name: pytest test execution adapter
    • new tests
      • pytest execution called with correct args
      • Debug launched correctly for pytest
      • launches testIdServer correct, with correct args and sends payload
  • testDiscoveryAdapter (unittest)
    • suite name: Unittest test discovery adapter
    • new tests
      • discovery should call sendCommand with correct basic args
  • testExecutionAdapter (unittest)
    • suite name: Unittest test execution adapter
    • new tests
      • execution called with correct args
      • Debug launched correctly for unittest
      • launches testIdServer correct, with correct args and sends payload
  • workspaceTestAdapter
  • ResultResolver
    • TBD
  • sendCommand
    • TBD
  • testIDServer
    • TBD
@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Jun 9, 2023
@eleanorjboyd eleanorjboyd self-assigned this Jun 9, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 9, 2023
@eleanorjboyd eleanorjboyd added this to the June 2023 milestone Jun 9, 2023
eleanorjboyd added a commit that referenced this issue Jun 21, 2023
eleanorjboyd added a commit to eleanorjboyd/vscode-python that referenced this issue Jun 21, 2023
@karthiknadig karthiknadig added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Jun 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
@eleanorjboyd eleanorjboyd removed the needs PR Ready to be worked on label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants