Skip to content

Ensure extension gets activated when any python command is selected from the command palette #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Mar 19, 2019 · 4 comments
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 19, 2019

Todo:

  • Identify commands that do not activate the extension
  • Or identify commands, when selected display a message ...command not found

To test this, reload VSC every time and ensure no python file is open

@ericsnowcurrently
Copy link

ericsnowcurrently commented Mar 26, 2019

FYI, below are the commands I found in the code. There are 24 that activate the extension and 4 that do not.

activate the extension (24)

  • Python: Build Workspace Symbols
  • Python: Configure Unit Tests
  • Python: Create Terminal
  • Python: Debug All Unit Tests
  • Python: Discover Unit Tests
  • Python: Enable Linting
  • Python: Enable source map support for extension debugging
  • Python: Run Python File in Terminal
  • Python: Run Selection/Line in Django Shell
  • Python: Run Selection/Line in Python Terminal
  • Python: Go to Python Object
  • Python: Run Current Unit Test File
  • Python: Run Failed Unit Tests
  • Python: Run All Unit Tests
  • Python: Debug Unit Test Method ...
  • Python: Run Unit Test File ...
  • Python: Run Unit Test Method ...
  • Python: Select Interpreter
  • Python: Select Linter
  • Python Refactor: Sort Imports
  • Python: Start REPL
  • Python: Update Workspace PySpark Libraries
  • Python: Show Output
  • Python: Show Unit Test Output

do not activate the extension (4)

  • Python Refactor: Extract Method
  • Python Refactor: Extract Variable
  • Python: Run Linting
  • Python: Stop

Note: I did not check the datascience commands. (There are 24 of them.)

@ericsnowcurrently
Copy link

ericsnowcurrently commented Mar 26, 2019

activates; does its thing

  • Python: Create Terminal
  • Python: Enable Linting
    • opens quick pick (updates user settings)
  • Python: Enable source map support for extension debugging
    • opens warning about performance
    • clicking button reloads window without extension activated
    • source map support remains activated in subsequent windows
  • Python: Select Interpreter
    • opens quick pick (updates user settings)
  • Python: Select Linter
    • opens quick pick (updates user settings)
  • Python: Start REPL
  • Python: Show Output

activates; "command '...' not found"

  • Python: Build Workspace Symbols
  • Python: Configure Unit Tests
  • Python: Debug All Unit Tests
  • Python: Discover Unit Tests
  • Python: Go to Python Object
  • Python: Run Current Unit Test File
  • Python: Run Failed Unit Tests
  • Python: Run All Unit Tests
  • Python: Debug Unit Test Method ...
  • Python: Run Unit Test File ...
  • Python: Run Unit Test Method ...
  • Python: Show Unit Test Output

activates; other error

  • Python: Run Python File in Terminal
    • "No open file to run in terminal"
  • Python Refactor: Sort Imports
    • "Please open a Python file to sort the imports."
  • Python: Update Workspace PySpark Libraries
    • "Make sure you have ..."
    • "Failed to update ..."

activates; other behavior

  • Python: Run Selection/Line in Django Shell
    • nothing else happens (no error about no selection/line)
  • Python: Run Selection/Line in Python Terminal
    • nothing else happens (no error about no selection/line)

does not activate (as expected); "command '...' not found"

  • Python Refactor: Extract Method
  • Python Refactor: Extract Variable
  • Python: Run Linting

does not show up in command palette

  • Python: Stop

@ericsnowcurrently ericsnowcurrently removed their assignment Mar 26, 2019
@ericsnowcurrently ericsnowcurrently added feature-* debt Covers everything internal: CI, testing, refactoring of the codebase, etc. bug Issue identified by VS Code Team member as probable bug and removed triage debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 26, 2019
@luabud luabud added area-editor-* User-facing catch-all and removed feature-* labels May 13, 2020
@kimadeline
Copy link

Somewhat related: #10441

@karrtikr
Copy link

Closing as dup of #10489

@karrtikr karrtikr added this to the October 2021 milestone Oct 22, 2021
@karrtikr karrtikr added the verified Verification succeeded label Oct 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants