-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Identify conda and windows store environments from given interpreter path #13589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13589 +/- ##
==========================================
- Coverage 59.86% 59.80% -0.07%
==========================================
Files 670 675 +5
Lines 37295 37798 +503
Branches 5335 5445 +110
==========================================
+ Hits 22326 22604 +278
- Misses 13815 14019 +204
- Partials 1154 1175 +21
Continue to review full report at Codecov.
|
Should this logic really be in a single low-level component? It seems strange that there's a bunch of code that's "common", but which contains conda-specific details in practice - shouldn't that all be in the conda locator instead? |
Since we don't have the templates for the (new) locators ready. I am putting them here for now. My plan is to move the isConda, isWindowsStore, etc, into respective locators. Even there i think these would be exposed as flat functions. Since they don't really need any state. As for the |
Kudos, SonarCloud Quality Gate passed!
|
This API is not consumed any where. This is adding all the low-level APIs we need for environment identification. In this PR, there is code to identify conda and windows store environments.