-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Ideas for speeding up and including flakey tests in PR #14265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14265 +/- ##
==========================================
- Coverage 59.96% 59.94% -0.03%
==========================================
Files 706 706
Lines 39180 39180
Branches 5681 5681
==========================================
- Hits 23494 23485 -9
- Misses 14449 14455 +6
- Partials 1237 1240 +3
Continue to review full report at Codecov.
|
I can't get Azdo to run again. Uggh. |
on: | ||
pull_request: | ||
branches: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weed can optionally run this same workflow in ci (commits to main),
This way we have three running on main branch for every commit, and we don't need to copy paste this (just a thought, copy paste sux)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's a 'push' right? Added that.
@karthiknadig we're splitting our DS functional tests out into github actions. This is so we can make them run faster and run with real juptyer during a PR. RIght now they won't be required, but this is the first step in the split. Thought you might want to know since they'll be running on core submissions too. Although I think I can prevent that with an inclusion list? |
Woot! It worked. 23 minutes for the longest one now. That's the native editor tests. |
Codecov Report
@@ Coverage Diff @@
## main #14265 +/- ##
=======================================
Coverage ? 59.94%
=======================================
Files ? 706
Lines ? 39180
Branches ? 5681
=======================================
Hits ? 23485
Misses ? 14455
Partials ? 1240 Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed!
|
This should hopefully make tests run fast enough to run on a PR.
It does this:
Some preliminary timing
That was without Jupyter though. This PR should try the same thing with Jupyter
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).