forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix multiprocessing problems with setting __file__ #14376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Make sure not to set ```__file__``` unless necessary as this can mess up some modules (like multiprocessing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ import { reportAction } from '../progress/decorator'; | |
import { ReportableAction } from '../progress/types'; | ||
import { IJupyterConnection, ISessionWithSocket } from '../types'; | ||
import { JupyterInvalidKernelError } from './jupyterInvalidKernelError'; | ||
import { JupyterWaitForIdleError } from './jupyterWaitForIdleError'; | ||
import { JupyterWebSockets } from './jupyterWebSocket'; | ||
import { getNameOfKernelConnection } from './kernels/helpers'; | ||
import { KernelConnectionMetadata } from './kernels/types'; | ||
|
@@ -90,9 +91,13 @@ export class JupyterSession extends BaseJupyterSession { | |
// Make sure it is idle before we return | ||
await this.waitForIdleOnSession(newSession, timeoutMS); | ||
} catch (exc) { | ||
traceError('Failed to change kernel', exc); | ||
// Throw a new exception indicating we cannot change. | ||
throw new JupyterInvalidKernelError(kernelConnection); | ||
if (exc instanceof JupyterWaitForIdleError) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Related fix? Just something you noticed at the same time? |
||
throw exc; | ||
} else { | ||
traceError('Failed to change kernel', exc); | ||
// Throw a new exception indicating we cannot change. | ||
throw new JupyterInvalidKernelError(kernelConnection); | ||
} | ||
} | ||
|
||
return newSession; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, even aside from fixing the bug seems better from a perf standpoint.