Skip to content

Remove unused code #15718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Remove unused code #15718

merged 1 commit into from
Mar 23, 2021

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Mar 19, 2021

Closes #15717

@karthiknadig karthiknadig added the skip tests Updates to tests unnecessary label Mar 19, 2021
@karthiknadig karthiknadig marked this pull request as ready for review March 19, 2021 07:40
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC Eric added certain display helpers that are not used currently. Please verify that we aren't removing those utils.

@codecov-io
Copy link

Codecov Report

Merging #15718 (9b1b21f) into main (e3e773a) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            main   #15718    +/-   ##
=======================================
  Coverage     65%      65%            
=======================================
  Files        551      551            
  Lines      26342    26112   -230     
  Branches    3802     3761    -41     
=======================================
- Hits       17235    17179    -56     
+ Misses      8378     8204   -174     
  Partials     729      729            
Impacted Files Coverage Δ
src/client/activation/types.ts 100% <ø> (ø)
src/client/application/diagnostics/types.ts 100% <ø> (ø)
src/client/common/constants.ts 100% <ø> (ø)
src/client/common/editor.ts 9% <ø> (-1%) ⬇️
src/client/common/helpers.ts 100% <ø> (+36%) ⬆️
src/client/common/platform/errors.ts 100% <ø> (+1%) ⬆️
src/client/common/platform/types.ts 100% <ø> (ø)
...rc/client/common/process/internal/scripts/index.ts 68% <ø> (+3%) ⬆️
src/client/common/process/types.ts 100% <ø> (ø)
src/client/common/types.ts 100% <ø> (ø)
... and 22 more

@karthiknadig karthiknadig merged commit a478613 into microsoft:main Mar 23, 2021
@karthiknadig karthiknadig deleted the prune1 branch March 24, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused code
3 participants