Support the Black formatter #1611
Conversation
Co-authored-by: Josh Smeaton <[email protected]>
| return InstallerResponse.Installed; | ||
| } | ||
| return InstallerResponse.Ignore; | ||
| const item = await this.appShell.showErrorMessage(`Formatter ${productName} is not installed. Install?`, 'Yes', 'No'); |
There was a problem hiding this comment.
This changes the UX, the user has no way to choose a different formatter here.
There was a problem hiding this comment.
Right, but you can't install a different linter either when that doesn't exist. I could update it to disable formatting instead of "No" to be more like the linting scenario?
There was a problem hiding this comment.
Yes, but earlier the user was aware of the fact that they had other formatters, with this new UX they won't know. Not until they poke around the docs or settings (majority of the users won't).
Codecov Report
@@ Coverage Diff @@
## master #1611 +/- ##
==========================================
+ Coverage 71.31% 71.44% +0.13%
==========================================
Files 273 274 +1
Lines 12700 12723 +23
Branches 2282 2285 +3
==========================================
+ Hits 9057 9090 +33
+ Misses 3502 3493 -9
+ Partials 141 140 -1
Continue to review full report at Codecov.
|
Fixes #1153
This pull request:
Co-authored-by: Josh Smeaton [email protected]