Skip to content

Fix flask app variable in debug configuration and flask unit tests #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2018

Conversation

DonJayamanne
Copy link

Fixes #1634
Fixes #1640

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

@@ -0,0 +1 @@
Fix unit tests used to test flask template debugging on AppVeyor for the exeprimental debugger.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: experimental

@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #1641 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1641      +/-   ##
==========================================
- Coverage   71.62%   71.53%   -0.09%     
==========================================
  Files         277      277              
  Lines       12816    12816              
  Branches     2299     2299              
==========================================
- Hits         9179     9168      -11     
- Misses       3502     3508       +6     
- Partials      135      140       +5
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 45.83% <0%> (-5.42%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 54.27% <0%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 128d231...2e78a71. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 2324754 into microsoft:master May 8, 2018
@DonJayamanne DonJayamanne deleted the issue1634 branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flask template debugging on AppVeyor for Experimental debugger Flask debugger configuration fails (Window) with "could not import" message
2 participants