Changes to IntelliCode and engine downloads #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailArkhipov
commented
May 21, 2018
MikhailArkhipov
commented
- Remove user-visible Pythia flag
- Rename it to IntelliCode
- Remove download of Pythia model, it is to be done by a separate extension
- Fold Linux build back to a single linux-x64 since it works in .NET Core 2.1
- Remove packaging of MSIL libraries as check for .NET Runtime is not reliable
added 22 commits
May 3, 2018 11:59
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
+ Coverage 71.71% 71.84% +0.12%
==========================================
Files 277 277
Lines 13043 12999 -44
Branches 2349 2336 -13
==========================================
- Hits 9354 9339 -15
+ Misses 3548 3524 -24
+ Partials 141 136 -5
Continue to review full report at Codecov.
|
DonJayamanne
requested changes
May 21, 2018
| @@ -99,7 +99,8 @@ export interface IPythonSettings { | |||
| readonly pythonPath: string; | |||
| readonly venvPath: string; | |||
| readonly venvFolders: string[]; | |||
| readonly pythiaEnabled: boolean; | |||
| readonly intelliCodeEnabled: boolean; | |||
There was a problem hiding this comment.
Don't we need to define these two settings (intelliCodeEnabled and downloadCodeAnalysis ) in package.json?
There was a problem hiding this comment.
Not yet. IntelliCode functionality is not public yet and disabling download is for contributors only (or us).
DonJayamanne
approved these changes
May 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.