Skip to content

Fix auto-indentation issues and remove formatOnType functionality #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DonJayamanne
Copy link

Fixes #1461
Fixes #1586

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #1750 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
- Coverage   73.76%   73.66%   -0.11%     
==========================================
  Files         279      275       -4     
  Lines       13049    12950      -99     
  Branches     2329     2317      -12     
==========================================
- Hits         9626     9539      -87     
+ Misses       3287     3278       -9     
+ Partials      136      133       -3
Impacted Files Coverage Δ
src/client/extension.ts 96.06% <ø> (-0.13%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (-0.66%) ⬇️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386df1f...35d6302. Read the comment docs.

@DonJayamanne DonJayamanne deleted the issue1461FormatIssues branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove editor.formatOnType support Indentation not made after a function parameter list with a type hint
1 participant