Skip to content

Mark tool paths scope as machine-overridable #18008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

ssbarnea
Copy link

@ssbarnea ssbarnea commented Nov 11, 2021

This change should prevent accidental syncing of these settings across machines. I had a similar bug on our vscode-ansible extension which I sorted by switching from resource scope to `machine-overridable.

Related: #17999

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please add a news entry. See news/README.md for instructions.

@karrtikr karrtikr added the skip package*.json package.json and package-lock.json don't both need updating label Nov 11, 2021
@ssbarnea ssbarnea requested a review from karrtikr November 11, 2021 15:21
@karrtikr karrtikr added this to the November 2021 milestone Nov 15, 2021
@karrtikr karrtikr merged commit 62ae848 into microsoft:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants