Bump vscode-tas-client #22490
Closed
Bump vscode-tas-client #22490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
commented
Nov 17, 2023
Comment on lines
+1
to
+13
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| // For some reason exporting it directly from 'vscode-tas-client' doesn't work well in unit tests with sinon. | ||
| // export { getExperimentationService } from 'vscode-tas-client'; | ||
| // Hence getting it using require... | ||
|
|
||
| import type * as tasClientTypes from 'vscode-tas-client'; | ||
|
|
||
| // eslint-disable-next-line global-require | ||
| const tasClient = require('vscode-tas-client') as typeof tasClientTypes; | ||
|
|
||
| export const { getExperimentationService } = tasClient; |
There was a problem hiding this comment.
I tried investigating what changed in the definition files, but couldn't find anything obvious. Hence going with this workaround.
karrtikr
added
the
debt
|
Closing, we have a better fix with sinon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22461