Skip to content

Rename pythonFiles to python_files #22921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Feb 15, 2024

closes #22665

@karthiknadig karthiknadig self-assigned this Feb 15, 2024
@karthiknadig karthiknadig added the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Feb 15, 2024
@karthiknadig karthiknadig marked this pull request as ready for review February 15, 2024 21:59
@karthiknadig
Copy link
Member Author

@eleanorjboyd @anthonykim1 This touches a lot of what you have worked on. After merging if something breaks and I am not around feel free to revert it.

@karthiknadig karthiknadig enabled auto-merge (squash) February 15, 2024 22:00
@vscodenpa vscodenpa added this to the February 2024 milestone Feb 15, 2024
@karthiknadig karthiknadig merged commit 27783ce into microsoft:main Mar 1, 2024
@karthiknadig karthiknadig deleted the rename1 branch March 1, 2024 21:28
@gitcnd
Copy link

gitcnd commented Apr 5, 2024

This appears to have broken VSCode integration with 3rd party products (e.g. Autodesk Fusion) - nobody can edit or debug anything now?

wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
@karthiknadig
Copy link
Member Author

@gitcnd That looks like a bug on (Autodesk Fusion). We have API that 3rd party extensions can use to access various features and libs that we ship. The internal locations of things can change as build new things or add new features, the APIs are there to prevent these internal changes from impacting consumers.

@brianekins
Copy link

brianekins commented Apr 5, 2024

@karthiknadig, could you please provide a link to the documentation for this API? I did some searching, and all I keep finding is the API for extensions. Thanks.

@karthiknadig
Copy link
Member Author

@brianekins What are you particularly looking for?
https://www.npmjs.com/package/@vscode/python-extension

If you are looking for debugger path API it should be here: https://github.com/microsoft/vscode-python/blob/main/pythonExtensionApi/src/main.ts and you can access it from @vscode/python-extension npm package.

@brianekins
Copy link

brianekins commented Apr 5, 2024

@karthiknadig, thank you. I'm looking for the API you mentioned that Autodesk should use to find the folder that VS Code uses for Python files. They're running a Python script that needs to build the path. VS Code isn't running yet, so extensions aren't an option.

@karthiknadig
Copy link
Member Author

What is the exact path they are using?

wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
@brianekins
Copy link

@karthiknadig, Fusion supports writing and debugging Fusion scripts using VS Code. When a user runs a command in Fusion to edit a script, Fusion checks to see if VS Code is installed. If it's not, it gives the user a chance to install it. If it is installed, then the path to VS Code needs to be determined so Fusion can start up VS Code and configure it to use some Fusion-specific Python libraries. All of this happens before VS Code is running.

@karthiknadig
Copy link
Member Author

@brianekins That does not answer my question. This is just python extension, and under python_files we used to ship various python packages. These things are getting moved to their own extensions. Like debugger will not be available under python_files anymore. This is why we have APIs to access these things independent of the location. the debugger is getting moved to a different extension.

Fusion checks to see if VS Code is installed. If it's not, it gives the user a chance to install it. If it is installed, then the path to VS Code needs to be determined so Fusion can start up VS Code and configure it to use some Fusion-specific Python libraries. All of this happens before VS Code is running.

Are you talking about path to the debugger (which is a python package called debugpy). Path to VS Code has nothing to do with python extension or the content under python_files. Also, if Fusion depends on debugpy it can install debugpy directly. Why does it try to find it from python extension.

karthiknadig pushed a commit that referenced this pull request Jun 17, 2024
#22921 removed executable bits:
```diff
diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate
old mode 100755
new mode 100644
similarity index 100%
rename from pythonFiles/deactivate/bash/deactivate
rename to python_files/deactivate/bash/deactivate
```


https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d

Set them back.


Fixes #23449 and #23195
DonJayamanne pushed a commit that referenced this pull request Jun 24, 2024
#22921 removed executable bits:
```diff
diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate
old mode 100755
new mode 100644
similarity index 100%
rename from pythonFiles/deactivate/bash/deactivate
rename to python_files/deactivate/bash/deactivate
```


https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d

Set them back.


Fixes #23449 and #23195
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this pull request Jun 28, 2024
microsoft#22921 removed executable bits:
```diff
diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate
old mode 100755
new mode 100644
similarity index 100%
rename from pythonFiles/deactivate/bash/deactivate
rename to python_files/deactivate/bash/deactivate
```


https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d

Set them back.


Fixes microsoft#23449 and microsoft#23195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isolate Python code so it doesn't conflict with user code
5 participants