-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Rename pythonFiles
to python_files
#22921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eleanorjboyd @anthonykim1 This touches a lot of what you have worked on. After merging if something breaks and I am not around feel free to revert it. |
This appears to have broken VSCode integration with 3rd party products (e.g. Autodesk Fusion) - nobody can edit or debug anything now? |
@gitcnd That looks like a bug on (Autodesk Fusion). We have API that 3rd party extensions can use to access various features and libs that we ship. The internal locations of things can change as build new things or add new features, the APIs are there to prevent these internal changes from impacting consumers. |
@karthiknadig, could you please provide a link to the documentation for this API? I did some searching, and all I keep finding is the API for extensions. Thanks. |
@brianekins What are you particularly looking for? If you are looking for debugger path API it should be here: https://github.com/microsoft/vscode-python/blob/main/pythonExtensionApi/src/main.ts and you can access it from @vscode/python-extension npm package. |
@karthiknadig, thank you. I'm looking for the API you mentioned that Autodesk should use to find the folder that VS Code uses for Python files. They're running a Python script that needs to build the path. VS Code isn't running yet, so extensions aren't an option. |
What is the exact path they are using? |
@karthiknadig, Fusion supports writing and debugging Fusion scripts using VS Code. When a user runs a command in Fusion to edit a script, Fusion checks to see if VS Code is installed. If it's not, it gives the user a chance to install it. If it is installed, then the path to VS Code needs to be determined so Fusion can start up VS Code and configure it to use some Fusion-specific Python libraries. All of this happens before VS Code is running. |
@brianekins That does not answer my question. This is just python extension, and under
Are you talking about path to the debugger (which is a python package called |
#22921 removed executable bits: ```diff diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivate ``` https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d Set them back. Fixes #23449 and #23195
#22921 removed executable bits: ```diff diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivate ``` https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d Set them back. Fixes #23449 and #23195
microsoft#22921 removed executable bits: ```diff diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivate ``` https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d Set them back. Fixes microsoft#23449 and microsoft#23195
closes #22665