Skip to content

Re-factor code python execution framework #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 115 commits into from
Dec 5, 2017
Merged
Show file tree
Hide file tree
Changes from 111 commits
Commits
Show all changes
115 commits
Select commit Hold shift + click to select a range
ecc1ca9
Fix Microsoft/vscode#37627 (#1368)
octref Nov 3, 2017
7c5778c
Version 0.7.0 of extension (#1381)
DonJayamanne Nov 9, 2017
9d1bf82
Update README.md
DonJayamanne Nov 9, 2017
ffba179
Update README.md
DonJayamanne Nov 9, 2017
905c713
sync fork with upstream
DonJayamanne Nov 10, 2017
acc2109
fix readme
DonJayamanne Nov 10, 2017
d470523
Merge branch 'master' of https://github.com/Microsoft/vscode-python
DonJayamanne Nov 16, 2017
d32a546
run without debugging
DonJayamanne Nov 15, 2017
3f14d0a
send terminated event when process ends and fix linters
DonJayamanne Nov 15, 2017
f37803f
gracefully handle program termination
DonJayamanne Nov 16, 2017
d69940e
use vscode infrastructure to launch code in terminals
DonJayamanne Nov 16, 2017
d392e8b
merged upstream
DonJayamanne Nov 16, 2017
11c9514
merged
DonJayamanne Nov 16, 2017
38befc0
ensure to check if launchArgs is not null
DonJayamanne Nov 16, 2017
bea91fc
ensure to check if launchArgs is not null
DonJayamanne Nov 16, 2017
0bb9054
ensure to check if launchArgs is not null
DonJayamanne Nov 16, 2017
a105a20
fix code review comments
DonJayamanne Nov 17, 2017
8b2fd7c
fixed code review comments
DonJayamanne Nov 17, 2017
5a7d21e
Merge branch 'master' into RunWithoutDebug
DonJayamanne Nov 17, 2017
acd90c5
Merge branch 'master' into RunWithoutDebug
DonJayamanne Nov 17, 2017
09b3359
fixes #250, do not copy all env variables
DonJayamanne Nov 17, 2017
9616eef
bug fix, launch using vscode and then fallback
DonJayamanne Nov 17, 2017
f9fe2a8
fix linter issue
DonJayamanne Nov 17, 2017
4963632
platform process services
DonJayamanne Nov 17, 2017
edbe63e
tests for decoder
DonJayamanne Nov 18, 2017
47acd08
tests for process service
DonJayamanne Nov 18, 2017
284e221
test to check source
DonJayamanne Nov 18, 2017
b27496b
tests for process utils
DonJayamanne Nov 20, 2017
92f775f
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 20, 2017
23fe3da
fix imports
DonJayamanne Nov 20, 2017
0277ca1
rename file
DonJayamanne Nov 20, 2017
bbc8290
environment variable parser
DonJayamanne Nov 21, 2017
29b5489
refactored variable services
DonJayamanne Nov 21, 2017
5e7a61b
environment variable caching service
DonJayamanne Nov 21, 2017
81af0e5
remove unwanted file
DonJayamanne Nov 21, 2017
e0ea914
process execution with unit tests
DonJayamanne Nov 21, 2017
f0c1978
process execution with unit tests
DonJayamanne Nov 21, 2017
32a6e53
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 21, 2017
4b30f2c
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 22, 2017
e396752
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 22, 2017
4c0bdb1
merged master
DonJayamanne Nov 22, 2017
3b71463
ensure env vars are always provided
DonJayamanne Nov 22, 2017
b5d9b1a
use range instead of xrange
DonJayamanne Nov 23, 2017
56ce88b
import reflect-metadata
DonJayamanne Nov 23, 2017
eff4792
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
4553c28
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
6382e96
added unit tests for python process and other services
DonJayamanne Nov 28, 2017
8ab2eb5
clean up of test runners and collectors
DonJayamanne Nov 28, 2017
39f272f
merged master
DonJayamanne Nov 28, 2017
b05a940
fix debugging unit tests and issue with used ports
DonJayamanne Nov 28, 2017
5049ed9
refactor code
DonJayamanne Nov 28, 2017
3c6520a
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
966e516
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
63d2d65
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
f6d469e
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 28, 2017
eced312
Merge branch 'master' into FixCodeExec
DonJayamanne Nov 29, 2017
ce930dc
fix for rx compilation issues
DonJayamanne Nov 29, 2017
53bbc1e
fixed linter issues and injected test debug launcher
DonJayamanne Nov 29, 2017
f0c4714
improvements to build scripts
DonJayamanne Nov 29, 2017
db0e778
update
DonJayamanne Nov 29, 2017
024509d
udpates to launc and tasks
DonJayamanne Nov 29, 2017
a32f846
add package-lock
DonJayamanne Nov 29, 2017
83a1ce5
fix linter errors
DonJayamanne Nov 29, 2017
560752b
add gulp-debounced-watch
DonJayamanne Nov 30, 2017
1addf10
refactor
DonJayamanne Nov 30, 2017
73c7c81
refactor unit tests to use DI
DonJayamanne Nov 30, 2017
07a8a18
read env variable instead on demand
DonJayamanne Nov 30, 2017
b4f5c10
refactor
DonJayamanne Nov 30, 2017
f14df93
fix #327, handle all promise rejections
DonJayamanne Nov 30, 2017
e856fe8
remove invalid item
DonJayamanne Nov 30, 2017
029e055
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 30, 2017
f0ba6d7
fixes to move interfaces around for DI
DonJayamanne Nov 30, 2017
6dcf879
improved bounce
DonJayamanne Nov 30, 2017
71c2531
bug fix
DonJayamanne Nov 30, 2017
e8c71c0
Merge remote-tracking branch 'upstream/master'
DonJayamanne Nov 30, 2017
b5c51c4
merged master
DonJayamanne Nov 30, 2017
7e6ee4c
DI for unit tests
DonJayamanne Dec 1, 2017
51cf9d2
Merge remote-tracking branch 'upstream/master'
DonJayamanne Dec 1, 2017
13df41b
perf improvement
DonJayamanne Dec 1, 2017
4968ebd
improvements
DonJayamanne Dec 1, 2017
7aadc43
Merge remote-tracking branch 'upstream/master'
DonJayamanne Dec 1, 2017
aa4062e
incremental changes
DonJayamanne Dec 1, 2017
9ef2465
refactored
DonJayamanne Dec 1, 2017
0e15e8d
pytest tests
DonJayamanne Dec 1, 2017
5a60422
add tests for nosetests
DonJayamanne Dec 1, 2017
5cfb06f
added more nose tests
DonJayamanne Dec 2, 2017
b2b7dc6
better options
DonJayamanne Dec 2, 2017
35b8255
fix issue
DonJayamanne Dec 2, 2017
7854924
reduce tests
DonJayamanne Dec 2, 2017
d69fd1a
remove duplicate registration
DonJayamanne Dec 2, 2017
317cf88
use mock out put for format tests
DonJayamanne Dec 2, 2017
07e0710
debug
DonJayamanne Dec 2, 2017
9e0d27a
debug
DonJayamanne Dec 2, 2017
5a22791
Fix tests
DonJayamanne Dec 2, 2017
fec7d51
Merge branch 'master' into FixCodeExec
DonJayamanne Dec 2, 2017
0c4003f
Merge branch 'FixCodeExec' of https://github.com/DonJayamanne/pythonV…
DonJayamanne Dec 2, 2017
9d6194b
removed unused method
DonJayamanne Dec 2, 2017
34158ba
speed up gulp
DonJayamanne Dec 4, 2017
c823315
removed unwanted setting
DonJayamanne Dec 4, 2017
e349e56
ensure chai 4.0.6 is used in tsd
DonJayamanne Dec 4, 2017
a1fea85
fixes
DonJayamanne Dec 4, 2017
cb0a354
bitwise operations are allowed
DonJayamanne Dec 4, 2017
f0f5c59
Merge remote-tracking branch 'upstream/master'
DonJayamanne Dec 4, 2017
c464a2a
merged
DonJayamanne Dec 4, 2017
011dca1
enforce eol in vscode
DonJayamanne Dec 4, 2017
bfb8036
enforce new line
DonJayamanne Dec 4, 2017
761f057
removed ts coding conventions
DonJayamanne Dec 4, 2017
b2b9da9
Merge remote-tracking branch 'upstream/master'
DonJayamanne Dec 4, 2017
51b6c81
Use spaces instead of tabs
DonJayamanne Dec 4, 2017
7fd36fc
merged master
DonJayamanne Dec 4, 2017
ada46ba
added missing license headers and fix linter warnings
DonJayamanne Dec 4, 2017
c5e2d5d
fix code comments
DonJayamanne Dec 5, 2017
b756ee8
fix code comments
DonJayamanne Dec 5, 2017
30a4091
Merge remote-tracking branch 'upstream/master'
DonJayamanne Dec 5, 2017
de14c78
merged
DonJayamanne Dec 5, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version
"tslint.enable": true,
"python.linting.enabled": false,
"python.formatting.formatOnSave": false,
"python.unitTest.promptToConfigure": false,
"python.workspaceSymbols.enabled": false,
"python.formatting.provider": "yapf"
"python.formatting.provider": "none",
"files.insertFinalNewline": true
}
20 changes: 20 additions & 0 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,26 @@
"isDefault": true
}
},
{
// Task that will replace 'Compile' and 'Hygiene', after having been battle-tested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"after having been" -> "after being"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my linguistic curiosity, but could you please explain the difference to a non-native speaker? "after having been" sounded fine to me...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, Bretts suggestion, makes sense to me.

"label": "Watch",
"type": "gulp",
"task": "watch",
"isBackground": true,
"presentation": {
"echo": true,
"reveal": "always",
"focus": false,
"panel": "shared"
},
"problemMatcher": [
"$tsc-watch",
{
"base": "$tslint5",
"fileLocation": "relative"
}
]
},
{
"label": "Hygiene (staged)",
"type": "gulp",
Expand Down
6 changes: 3 additions & 3 deletions CODING_STANDARDS.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ Use undefined. Do not use null.

### Comments

Use JSDoc style comments for functions, interfaces, enums, and classes.
* Comments must end with a period.
* Use JSDoc style comments for functions, interfaces, enums, and classes.

### Strings

Expand All @@ -42,5 +43,4 @@ Use single quotes for strings.

* `else` goes on a the same line from the closing curly brace.
* Use 4 spaces per indentation.


* All files must end with an empty line.
Loading