Skip to content

Update pytest parser to handle pytest 4.1 #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2019
Merged

Update pytest parser to handle pytest 4.1 #4098

merged 4 commits into from
Jan 23, 2019

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jan 23, 2019 •
edited
Loading

For #4099

  • Handles stdout produced by pytest in the 4.1 version without breaking < 4.1
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

d3r3kk added 2 commits January 22, 2019 20:33
@d3r3kk
Update pytest parser to handle pytest 4.0 through pytest 4.1
9a94d0f 
For microsoft#3911

- Handles stdout produced by pytest in the 4.0 and 4.1 series
@d3r3kk
news
9f1767d
@codecov
Copy link

codecov bot commented Jan 23, 2019 •
edited
Loading

Codecov Report

Merging #4098 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4098   +/-   ##
======================================
+ Coverage      79%     79%   +1%     
======================================
  Files         407     407           
  Lines       18644   18654   +10     
  Branches     3007    3009    +2     
======================================
+ Hits        14608   14618   +10     
  Misses       4033    4033           
  Partials        3       3
Flag Coverage Δ
#Linux 68% <95%> (+1%) ⬆️
#Windows 68% <95%> (+1%) ⬆️
#macOS 68% <95%> (+1%) ⬆️

@DonJayamanne
Copy link

DonJayamanne commented Jan 23, 2019 •
edited
Loading

@d3r3kk
Please change the news entry and point to #4099

also represents initial work for #4035

Not sure about this, cuz all of the code you have written will be obsolete, i.e. it's a fix for the old code.
Also #3911 is a meta issue for refactoring of pytest discovery.

DonJayamanne
DonJayamanne requested changes Jan 23, 2019
View reviewed changes
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change news entry to point to #4099

@d3r3kk
Add tests for pytest v4.1+
b37908c 
- update test labels to match pytest versions
- add test data specific to 4.1+
- rename news entry
@d3r3kk d3r3kk changed the title WIP - Update pytest parser to handle pytest 4.0 through pytest 4.1 Update pytest parser to handle pytest 4.1 Jan 23, 2019
@d3r3kk d3r3kk merged commit aaf9c6c into microsoft:master Jan 23, 2019
@d3r3kk d3r3kk deleted the 3911_pytest_parser_update branch January 23, 2019 18:55
DonJayamanne pushed a commit that referenced this pull request Jan 25, 2019
@d3r3kk @DonJayamanne
Update pytest parser to handle pytest 4.1 (#4098)
ccb6d75 
- Handles stdout produced by pytest in the 4.0 and 4.1 series
- update test labels to match pytest versions
- add test data specific to 4.1+
@Flamefire Flamefire mentioned this pull request Feb 8, 2019
Closed
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3r3kk @DonJayamanne