Skip to content

Add watermark for input box #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2019
Merged

Add watermark for input box #4117

merged 4 commits into from
Jan 24, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Jan 23, 2019

For #4111

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019 •
edited
Loading

Codecov Report

Merging #4117 into master will increase coverage by 1%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4117   +/-   ##
======================================
+ Coverage      79%     79%   +1%     
======================================
  Files         408     408           
  Lines       18764   18765    +1     
  Branches     3031    3031           
======================================
+ Hits        14713   14714    +1     
  Misses       4048    4048           
  Partials        3       3
Flag Coverage Δ
#Linux 68% <100%> (+1%) ⬆️
#Windows 69% <100%> (+1%) ⬆️
#macOS 68% <100%> (+1%) ⬆️

IanMatthewHuff
IanMatthewHuff approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 3332907 into master Jan 24, 2019
rchiodo added a commit that referenced this pull request Jan 24, 2019
@rchiodo
Add watermark for input box (#4117)
be74c5e 
* Add watermark for input box

* Add news entry

* Fix hygiene after merge
@rchiodo rchiodo deleted the rchiodo/add_watermark branch January 24, 2019 01:03
rchiodo added a commit that referenced this pull request Jan 24, 2019
@rchiodo
Add watermark for input box (#4117) (#4124)
5b78b08 
* Add watermark for input box

* Add news entry

* Fix hygiene after merge
DonJayamanne added a commit that referenced this pull request Jan 24, 2019
@DonJayamanne
Merge branch 'release' into mergeRelease1
cc3f7fa 
* release:
  Add watermark for input box (#4117) (#4124)
  Cherry pick fix input bugs into release (#4121)
  Update version of language server to 0.1.78 (#4080)
  Slow updates to pip (#4087)
  Release candidate for Jan 2019.1.1
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchiodo @IanMatthewHuff