Skip to content

Rchiodo/allow default theme #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Rchiodo/allow default theme #4770

merged 2 commits into from
Mar 18, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Mar 15, 2019

Allows user to always use the light theme in the
Python Interactive Window

For #4640

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

rchiodo added 2 commits March 14, 2019 17:16
Allows user to always use the light theme in the
Python Interactive Window
@rchiodo rchiodo self-assigned this Mar 15, 2019
@rchiodo rchiodo requested a review from IanMatthewHuff March 15, 2019 00:23
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #4770 into master will decrease coverage by 16%.
The diff coverage is 25%.

@@           Coverage Diff            @@
##           master   #4770     +/-   ##
========================================
- Coverage      77%     61%    -15%     
========================================
  Files         449     373     -76     
  Lines       21674   15199   -6475     
  Branches     3554    1257   -2297     
========================================
- Hits        16625    9250   -7375     
- Misses       5045    5744    +699     
- Partials        4     205    +201
Flag Coverage Δ
#Linux ?
#Windows ?
#macOS ?

Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit 8a8653d into master Mar 18, 2019
@rchiodo rchiodo deleted the rchiodo/allowDefaultTheme branch April 10, 2019 16:24
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants