Skip to content

Fixes bug while trying to run / debug a pyramid application on windows #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 42 commits into from
Closed

Conversation

jpfarias
Copy link

@jpfarias jpfarias commented Jan 3, 2018

The Pyramid debugger tries to find pserve on all platforms. On windows it should look for pserve.exe instead.

octref and others added 30 commits November 3, 2017 13:11
* 'master' of https://github.com/Microsoft/vscode-python:
  Fixes #56 list all environments (#219)
  Fixes #57 Disable activation on debugging (#220)
  Fixes #26 Do not run linters when linters are disabled (#222)
* upstream/master:
  Fix typo in README.md (#252)
  Disable linter without workspaces (#241)
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
* upstream/master:
  Resolve pythonPath before comparing it to shebang (#273)
* upstream/master:
  Fixes #22 to Detect anaconda from known locations  (#221)
  Use workspaceFolder token instead of workspaceRoot (#267)
  Fix registry lookup response (#224)
  Fix issues when running without debugging and debugged code terminates (#249)
* upstream/master:
  Fix debugging tests (#304)
* upstream/master:
  Remove jupyter functionality in favor of Jupyter extension (#302)
  Drop Python 2 URLs (#307)
* upstream/master:
  Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
* upstream/master:
  Remove setting linting.lintOnTextChange as it was never implemented (#315)
* upstream/master:
  Fix travis build error (#326)
* upstream/master:
  add new npm deps with improved gulp for dev (#328)
* upstream/master:
  Update version of inversify package (#329)
* upstream/master:
  Document our dev process (#330)
* upstream/master:
  Document contribution to the code along with coding standards (#321)
* upstream/master:
  Add Simplified Chinese translation of commands (#240)
* upstream/master:
  Fix package.json (#347)
* upstream/master:
  #34, #110 - suppress Intellisense in strings and comments (#339)
  Re-factor code python execution framework  (#345)
* upstream/master:
  Fix linters to make use of the new python code execution framework (#360)
  Update the versioning scheme (#356)
  Make npm happy in regards to line endings (#357)
* upstream/master:
  Ensure python path is not set if already set in user settings (#369)
  Use 'an' rather than 'a' before vowel words (#373)
* upstream/master:
  Use new environment variable parser (#362)
DonJayamanne and others added 11 commits December 11, 2017 15:00
* upstream/master:
  Fetch tooltip details on-demand for auto-completions (#368)
  Fix interpreter display (#391)
* upstream/master:
  Fix typo in completion details  (#396)
  Fix encoding (#394)
* upstream/master:
  Fix hover test (#398)
* upstream/master:
  Fix unicode unit test (#400)
* upstream/master:
  Pass execution arguments to linter when run as a stand alone executable (#406)
* upstream/master:
  Update the TPN (#415)
  0.9.0 release details (#407)
* upstream/master:
  Make use of new execution layer instead of spawning processes (#425)
  Use localhost instead of 0.0.0.0 for all local socket servers (#417)
  Provide full signature help with highlighted parameter (#416)
  Change `os.arch()` to `npm` `arch` to fix wrong arch detection. (#419)
  Document our Russian support (#424)
  Bump the version number to the next release as an alpha (#422)
  Russian translation (#411)
  Speed up virtual environment detection in workspace (#405)
* upstream/master:
  Refactor formatters to use new execution framework (#426)
* upstream/master:
  Release 0.9.1 (#458)
  Add localization for Japanese (#434)
  Add Svn to uriSchemesToIgnore (#443)
@DonJayamanne
Copy link

@jpfarias thanks for the PR, unfortunately some changes have been made since you submitted your PR, thereby causing the tests to fail.
Please could you resolve the issues and I'll look into this tomorrow.

@DonJayamanne DonJayamanne self-requested a review January 4, 2018 01:21
@DonJayamanne DonJayamanne modified the milestone: January 2018 Jan 4, 2018
@jpfarias jpfarias closed this Jan 4, 2018
jpfarias pushed a commit to jpfarias/vscode-python that referenced this pull request Jan 4, 2018
@DonJayamanne
Copy link

@jpfarias this PR too is failling. Looks like you haven't updated your fork.
Instructions to update your fork can be found here: https://help.github.com/articles/syncing-a-fork/

@jpfarias
Copy link
Author

jpfarias commented Jan 4, 2018

Yeah I didn't know how to sync so I removed my old repository and forked directly from Microsoft/vscode-python then submitted a new PR #530 which I think is synced already, even though it also failed here on github, the error on the log is network related so I doubt it is my fault :-)

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants