Skip to content

Reference to sample secrets file which doesn't exist #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
sjha2048 opened this issue Sep 23, 2021 · 1 comment · Fixed by #517
Closed
5 tasks done

Reference to sample secrets file which doesn't exist #516

sjha2048 opened this issue Sep 23, 2021 · 1 comment · Fixed by #517

Comments

@sjha2048
Copy link
Contributor

sjha2048 commented Sep 23, 2021

Bug Report

Prerequisites

  • Can you reproduce the problem?
  • Are you running the latest version?
  • Are you reporting to the correct repository?
  • Did you perform a cursory search?

Description

In /msgraph-sdk-javascript/blob/dev/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/index.js on L#11
some secrets are imported
const { clientId, clientSecret, scopes, tenantId } = require("./secrets");
I looked up in the repo and secrets.js doesn't exist but, secrets are defined in index.js only

It's a little bit confusing and gives an error when the user tries to run the file, also documentation is also a little bit ambiguous about defining the secrets.

Steps to Reproduce

Try running the sample without removing secrets import line

SDK Version - [SDK version you are using]

  • Node (Check, if using Node version of SDK)

Node Version - v16.10.0

Happy to update the documentation and secrets file.

@nikithauc
Copy link
Contributor

@sjha2048 Thanks for reporting this! PRs are always welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants