Skip to content

fix(samples): added secrets file and updated documentation #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

sjha2048
Copy link
Contributor

Summary

secrets.js didn't exist because it was added in gitignore, hence removed it from there and updated documentation for the same.

Closing issues

closes #516

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghost
Copy link

ghost commented Sep 27, 2021

CLA assistant check
All CLA requirements met.

@baywet baywet requested a review from nikithauc September 27, 2021 11:44
@nikithauc
Copy link
Contributor

@sjha2048 Thank you for your contribution!

@nikithauc nikithauc merged commit 22233e9 into microsoftgraph:dev Sep 28, 2021
@nikithauc nikithauc mentioned this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference to sample secrets file which doesn't exist
2 participants