Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ts #1896

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

Seifeldin-Sabry
Copy link

@Seifeldin-Sabry Seifeldin-Sabry commented Mar 6, 2025

exporting type to surpress the TS error: 'Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.'

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

NOTE: PR's will be accepted only in case of appropriate information is provided below

Summary

It was just a slight syntax to pass typescript Typechecking

Motivation

Explain the motivation for making this change. What existing problem does the pull request solve?

When using the token provider, app fails the type checks due to a missed syntax when re-exporting types.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

exporting type to surpress the TS error: 'Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.'
@Seifeldin-Sabry Seifeldin-Sabry requested a review from a team as a code owner March 6, 2025 07:05
Copy link

@Peter-512 Peter-512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants