fix!: don't delete "main" in package.json #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esbuild still doesn't support exports evanw/esbuild#187 it's uncertain as yet what impact this might have on other bundlers and loaders, hence this is a BREAKING CHANGE.
|
This won’t work on its own, the built package doesn’t have an index.js in the root, it has two directories for the esm and cjs builds, we’ll need to re-write this to ‘cjs/index.js’. |
|
doh! of course .. and I even did this for a pkg I manually fixed & published. |
rvagg
commented
Mar 6, 2021
| @@ -53,8 +53,7 @@ class Package { | |||
|
|
|||
| const exports = {} | |||
| if (!json.exports) { | |||
| if (!json.main) exports['.'] = { import: this.file(toURL('./index.js')) } | |||
| exports['.'] = { import: this.file(toURL(json.main)) } | |||
| exports['.'] = { import: this.file(toURL(json.main || './index.js')) } | |||
There was a problem hiding this comment.
noticed the above logic was a bit broken so I fixed it while in here, the if has no effect and the second line would be calling toURL(undefined) if there's no json.main.
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esbuild still doesn't support exports evanw/esbuild#187
it's uncertain as yet what impact this might have on other bundlers and
loaders, hence this is a BREAKING CHANGE.