feature/hash-cache-keys #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebronner
reviewed
Jan 11, 2018
.gitignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| /vendor | |||
| composer.lock | |||
| .*.sw? | |||
There was a problem hiding this comment.
This is probably best handled in your global git configuration. It's been considered "best practice" to leave out environment-specific ignores from the project's git-ignore.
mikebronner
requested changes
Jan 15, 2018
src/CachedModel.php
Outdated
| @@ -55,7 +55,7 @@ public static function all($columns = ['*']) | |||
| $class = get_called_class(); | |||
| $instance = new $class; | |||
| $tags = [str_slug(get_called_class())]; | |||
| $key = 'genealabslaravelmodelcachingtestsfixturesauthor'; | |||
| $key = sha1('genealabslaravelmodelcachingtestsfixturesauthor'); | |||
There was a problem hiding this comment.
Call makeCacheKey() here, this was bad code on my part.
There was a problem hiding this comment.
This won't work in a static function.
There was a problem hiding this comment.
I'm confused as to why the function is marked static in the first place. It is called like an object method.
There was a problem hiding this comment.
Something like this?
$key = $instance->makeCacheKey();There was a problem hiding this comment.
for instance in tests/Unit/CachedBuilderTest.php line 44.
mikebronner
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #48