Spelling changes #63
Merged
Spelling changes #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebronner
reviewed
Feb 9, 2018
| @@ -10,11 +10,11 @@ | |||
| [](https://raw.githubusercontent.com/GeneaLabs/laravel-model-caching/master/LICENSE) | |||
|
|
|||
| ## Impetus | |||
| I created this package in response to a client project that had complex, nested | |||
There was a problem hiding this comment.
The comma here was intentional.
mikebronner
reviewed
Feb 9, 2018
README.md
Outdated
| @@ -48,7 +48,7 @@ memcached). While this is optional, using a non-taggable cache provider will | |||
| mean that the entire cache is cleared each time a model is created, saved, | |||
| updated, or deleted. | |||
|
|
|||
| For ease of maintenance, I would recommend adding a `BaseModel` model that | |||
| For the ease of maintenance, I would recommend adding a `BaseModel` model that | |||
mikebronner
reviewed
Feb 9, 2018
README.md
Outdated
| @@ -66,7 +66,7 @@ abstract class BaseModel extends CachedModel | |||
| ``` | |||
|
|
|||
| ### Exception: User Model | |||
| I would not recommend caching the user model, as it is a special case, since it | |||
| I would not recommend caching the user model, as it is a special case since it | |||
There was a problem hiding this comment.
I believe the comma here is correct grammar
mikebronner
reviewed
Feb 9, 2018
README.md
Outdated
| @@ -100,7 +100,7 @@ you should see somewhere around 100% performance increase. | |||
|
|
|||
| ## Commitment to Quality | |||
| During package development I try as best as possible to embrace good design and | |||
| development practices to try to ensure that this package is as good as it can | |||
| development practices trying to ensure that this package is as good as it can | |||
There was a problem hiding this comment.
perhaps a comma is called for here instead: good design and development practices, to help ensure
mikebronner
requested changes
Feb 9, 2018
There was a problem hiding this comment.
Hi @fridzema thanks for the PR to try to keep my spelling adventures in check :) I made a few comments, if you could revert and update those as indicated, that would be great :) Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.