feat: add support for v4 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: afe9a3c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mikededo
force-pushed
the
feat/tailwind-v4
branch
from
e39bcdc to
6abc370
Compare
mikededo
force-pushed
the
feat/tailwind-v4
branch
from
b9032a2 to
f311a33
Compare
mikededo
force-pushed
the
feat/tailwind-v4
branch
from
7ceaaf2 to
14cb3b6
Compare
mikededo
force-pushed
the
feat/tailwind-v4
branch
from
575cd8d to
afe9a3c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for v4 configuration loading by switching dependency management from bun to pnpm, updating CLI commands in workflows and documentation, and converting the repository into a monorepo to streamline development.
- Remove outdated e2e/README.md content
- Update CONTRIBUTING.md and workflows to use pnpm instead of bun
- Add a changeset for tailwind v4 support
Reviewed Changes
Copilot reviewed 103 out of 118 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/README.md | Removed obsolete README content for e2e tests |
| CONTRIBUTING.md | Updated instructions to use pnpm for dependency management |
| .github/workflows/relase.yaml | Updated dependency installation/build commands and publish command |
| .github/workflows/ci.yaml | Replaced bun commands with pnpm commands in CI workflow steps |
| .changeset/shy-planes-mix.md | Introduced a changeset for tailwind v4 support |
Files not reviewed (15)
- e2e/snapshots/default-configuration/src/lib/components/button.svelte.snap: Language not supported
- e2e/snapshots/default-configuration/src/lib/components/icon-button/icon-button.svelte.snap: Language not supported
- e2e/snapshots/default-configuration/src/lib/components/icon-button/styles.ts.snap: Language not supported
- e2e/snapshots/default-configuration/src/lib/components/square.svelte.snap: Language not supported
- e2e/snapshots/default-configuration/src/routes/+layout.svelte.snap: Language not supported
- e2e/snapshots/default-configuration/src/routes/+page.svelte.snap: Language not supported
- e2e/snapshots/rules-configuration/src/lib/components/button.svelte.snap: Language not supported
- e2e/snapshots/rules-configuration/src/lib/components/icon-button/icon-button.svelte.snap: Language not supported
- e2e/snapshots/rules-configuration/src/lib/components/icon-button/styles.ts.snap: Language not supported
- e2e/snapshots/rules-configuration/src/lib/components/square.svelte.snap: Language not supported
- e2e/snapshots/rules-configuration/src/routes/+layout.svelte.snap: Language not supported
- e2e/snapshots/rules-configuration/src/routes/+page.svelte.snap: Language not supported
- e2e/snapshots/settings-configuration/src/lib/components/button.svelte.snap: Language not supported
- e2e/snapshots/settings-configuration/src/lib/components/icon-button/icon-button.svelte.snap: Language not supported
- e2e/snapshots/settings-configuration/src/lib/components/icon-button/styles.ts.snap: Language not supported
This was referenced Apr 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to v4 configuration loading, which involves the usage of workers as
ESLint rules cannot be executed asynchronously.
Since e2e test should be kept, there are two different folders for each test.
The repo has been converted into a monorepo to simplify the development and the
code structure.