General cleanup & formatting #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All class members explicitly marked either `public` or `private` * All class properties appear before the constructor, all class methods are after * All `public` class members appear before `private` class members * All methods have a return typedef, and all parameters have typedefs * All `if` statements are braced * Used a specific function signature with typed params instead of `Function` * Normalized whitespace * Interface members should terminate lines with a semicolon, not commas * Normalized all methods to return the same namespace of `IntroJs`. Before some returned that, and some returned the global `IntroJs.IntroJs` * Fixed a bug where `onHintsAdded` actually called the wrong method which was copy/pasted from the above method.
razoorka
approved these changes
Apr 23, 2018
|
This PR has been approved and just sitting hear for nearly a year... is this ever going to get merged in? |
|
Well after nearly 5 years I'm just gonna go ahead and close this to get it out of my list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes in a lot of the same changes in #1, and improves on them.
publicorprivatepublicclass members appear beforeprivateclass membersifstatements are bracedFunctionIntroJs. Before some returned that, and some returned the globalIntroJs.IntroJsonHintsAddedactually called the wrong method which was copy/pasted from the above method.