Skip to content
This repository was archived by the owner on Apr 15, 2025. It is now read-only.

Upgraded the app to be compatible with Django 1.10+ #1

Merged
merged 1 commit into from
Jul 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,17 @@ language: python

python:
- "2.7"
- "3.6"

env:
matrix:
- TOX_ENV=py27-dj14
- TOX_ENV=py27-dj15
- TOX_ENV=py27-dj16
- TOX_ENV=py27-dj17
- TOX_ENV=py27-dj18
- TOX_ENV=py33-dj15
- TOX_ENV=py33-dj16
- TOX_ENV=py33-dj17
- TOX_ENV=py33-dj18
- TOX_ENV=py34-dj15
- TOX_ENV=py34-dj16
- TOX_ENV=py34-dj17
- TOX_ENV=py34-dj18
- TOX_ENV=pypy-dj14
- TOX_ENV=pypy-dj15
- TOX_ENV=pypy-dj16
- TOX_ENV=pypy-dj17
- TOX_ENV=pypy-dj18
- TOX_ENV=py27-cov
- TOX_ENV=py27-dj19
- TOX_ENV=py27-dj100
- TOX_ENV=py36-dj18
- TOX_ENV=py36-dj19
- TOX_ENV=py36-dj100
- TOX_ENV=py36-cov

install:
- pip install tox
Expand Down
7 changes: 7 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,10 @@ This package provide various signals for you to get notification, and do more th
:target: https://travis-ci.org/StreetVoice/django-elastic-transcoder
.. |Coverage Status| image:: https://coveralls.io/repos/StreetVoice/django-elastic-transcoder/badge.png?branch=master
:target: https://coveralls.io/r/StreetVoice/django-elastic-transcoder?branch=master

Run Tests
-----------

.. code:: sh
$ pip install -r test_requirements.txt
$ tox
2 changes: 1 addition & 1 deletion dj_elastictranscoder/admin.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.contrib import admin
from .models import EncodeJob
from dj_elastictranscoder.models import EncodeJob

class EncodeJobAdmin(admin.ModelAdmin):
list_display = ('id', 'state', 'message')
Expand Down
2 changes: 1 addition & 1 deletion dj_elastictranscoder/migrations/0001_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Migration(migrations.Migration):
fields=[
('id', models.CharField(max_length=100, serialize=False, primary_key=True)),
('object_id', models.PositiveIntegerField()),
('state', models.PositiveIntegerField(default=0, db_index=True, choices=[(0, b'Submitted'), (1, b'Progressing'), (2, b'Error'), (3, b'Warning'), (4, b'Complete')])),
('state', models.PositiveIntegerField(choices=[(0, 'Submitted'), (1, 'Progressing'), (2, 'Error'), (3, 'Warning'), (4, 'Complete')], db_index=True, default=0)),
('message', models.TextField()),
('created_at', models.DateTimeField(auto_now_add=True)),
('last_modified', models.DateTimeField(auto_now=True)),
Expand Down
7 changes: 2 additions & 5 deletions dj_elastictranscoder/models.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
from django.db import models
from django.contrib.contenttypes.models import ContentType
import django
if django.get_version() >= '1.8':
from django.contrib.contenttypes.fields import GenericForeignKey
else:
from django.contrib.contenttypes.generic import GenericForeignKey
from django.contrib.contenttypes.fields import GenericForeignKey



class EncodeJob(models.Model):
Expand Down
49 changes: 0 additions & 49 deletions dj_elastictranscoder/south_migrations/0001_initial.py

This file was deleted.

Empty file.
2 changes: 1 addition & 1 deletion dj_elastictranscoder/transcoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from django.conf import settings
from django.contrib.contenttypes.models import ContentType

from .models import EncodeJob
from dj_elastictranscoder.models import EncodeJob


class Transcoder(object):
Expand Down
12 changes: 5 additions & 7 deletions dj_elastictranscoder/urls.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
try:
from django.conf.urls import url, patterns
except ImportError:
from django.conf.urls.defaults import url, patterns # Support for Django < 1.4
from django.conf.urls import url

from dj_elastictranscoder.views import endpoint as transcoder_endpoint

urlpatterns = (url(r'^endpoint/$', transcoder_endpoint, name='transcoder_endpoint'),)

urlpatterns = patterns('dj_elastictranscoder.views',
url(r'^endpoint/$', 'endpoint'),
)
4 changes: 2 additions & 2 deletions dj_elastictranscoder/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from django.views.decorators.csrf import csrf_exempt
from django.core.mail import mail_admins

from .models import EncodeJob
from .signals import (
from dj_elastictranscoder.models import EncodeJob
from dj_elastictranscoder.signals import (
transcode_onprogress,
transcode_onerror,
transcode_oncomplete
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
include_package_data=True,
zip_safe=False,
install_requires=[
"django >= 1.3, < 1.9",
"django >= 1.8",
"boto3 >= 1.1",
"South >= 0.8",
],
classifiers=[
"Intended Audience :: Developers",
Expand Down
1 change: 1 addition & 0 deletions test_requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
tox
1 change: 0 additions & 1 deletion testsapp/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ pytest
pytest-django
pytest-cov
boto
south
2 changes: 1 addition & 1 deletion testsapp/test_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
transcode_oncomplete
)

from .models import Item
from testsapp.models import Item



Expand Down
2 changes: 1 addition & 1 deletion testsapp/tests_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
]
SITE_ID = 1
DEBUG = False
ROOT_URLCONF = ''
ROOT_URLCONF = 'dj_elastictranscoder.urls'
SECRET_KEY='test'
21 changes: 9 additions & 12 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
[tox]
# for py 3.x we are using only django 1.6.x as 1.5.x had only "experimental py3 support"
envlist =
py{27,py}-dj{14,15,16,17,18},
py{33,34}-dj{15,16,17,18},
py27-cov
py{27}-dj{18,19,100},
py{36}-dj{18,19,100},
py36-cov
skipsdist = True
usedevelop = True

Expand All @@ -13,21 +12,19 @@ basepython =
py27: python2.7
py33: python3.3
py34: python3.4
pypy: pypy
py35: python3.5
py36: python3.6
deps =
-rtestsapp/requirements.txt
dj14: django>=1.4,<1.4.999
dj15: django>=1.5,<1.5.999
dj16: django>=1.6,<1.6.999
dj17: django>=1.7,<1.7.999
dj18: django>=1.8,<1.8.999
dj19: https://github.com/django/django/archive/master.tar.gz#egg=django
dj19: django>=1.9,<1.9.999
dj100: django>=1.10
setenv =
DJANGO_SETTINGS_MODULE = testsapp.tests_settings
PYTHONPATH = {toxinidir}/testsapp:{toxinidir}

[testenv:py27-cov]
[testenv:py36-cov]
commands = py.test --cov=dj_elastictranscoder
deps =
-rtestsapp/requirements.txt
django>=1.8,<1.8.999
django>=1.8