Support Phi-4-mini #216
Merged
Support Phi-4-mini #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DePasqualeOrg
force-pushed
the
phi-4-mini
branch
from
85a0501 to
00da9ff
Compare
Closed
awni
reviewed
Feb 27, 2025
Comment on lines
59
to
66
| // Extension to Embedding to support using it as a linear layer | ||
| extension Embedding { | ||
| public func asLinear(_ x: MLXArray) -> MLXArray { | ||
| // Use the embedding weights as a linear layer | ||
| // This is equivalent to x @ weight.T | ||
| return matmul(x, weight.transposed()) | ||
| } | ||
| } |
There was a problem hiding this comment.
The embedding layer already has that: https://github.com/ml-explore/mlx-swift/blob/main/Source/MLXNN/Embedding.swift#L39-L45
Can you remove that code?
There was a problem hiding this comment.
Thanks, I've removed it.
DePasqualeOrg
force-pushed
the
phi-4-mini
branch
from
00da9ff to
0ac6107
Compare
davidkoski
reviewed
Feb 27, 2025
| return model.embedTokens.asLinear(out) | ||
| } else { | ||
| return lmHead!(out) | ||
| } |
There was a problem hiding this comment.
I suggest using this structure -- what is here matches the python but I think this is more idiomatic swift:
if let lmHead {
out = lmHead(out)
} else {
out = model.embedTokens.asLinear(out)
}(fine with the returns rather than the out =, but the if let is better I think)
There was a problem hiding this comment.
Thanks. I've used your suggestion and added a fatal error for the fall-through case, which shouldn't normally happen.
davidkoski
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ml-explore/mlx-examples#1305
I've verified that this works in llm-tool with these arguments:
--model microsoft/Phi-4-mini-instruct --prompt "Write a story about Einstein" -m 2048I've also verified that it works with Phi 3.5 mini and Phi 4.
This is ready for review.