add load_from_std_lib function to Lua state
#136
Conversation
|
Sorry for sitting on this for so long... I've been trying to figure out exactly what I'm going to do re: #116 for a while, and this PR sort of overlaps with it. I still need to figure out what I'm going to do, and that will affect everything that loads the Lua stdlib, but I don't think that's a valid reason to wait on this PR, since this is still a strict improvement. Would it be possible to just combine the body here with the code that loads libraries in |
|
No worries. Not sure why I didn't do this in the first place. Force-pushed with the big block of Also, CI seems to be failing on some not totally backwards compatible change to rust in 1.35 -> 1.36 that's causing rustyline to fail to build. |
|
You can go ahead and push that as part of this PR if you don't mind, I don't mind the drive-by change honestly. |
|
There was also a test case failing due to some changes in what errors the compiler produces for broken code. Updated a couple of tests in |
src/lua.rs
Outdated
| /// | ||
| /// This function is unsafe because it can be used to load the `debug` library which can be used | ||
| /// to break the safety guarantees provided by rlua. | ||
| pub unsafe fn load_from_std_lib(&self, lua_mod: StdLib) -> Result<()> { |
There was a problem hiding this comment.
Could this be load_std_lib and also can there be an unsafe_load_std_lib variant that allows debug, similar to new_with_debug?
(new_with_debug is probably going to be renamed to unsafe_new when other things that the debug library are considered unsafe)
There was a problem hiding this comment.
load_std_lib implies to me that it loads the whole std lib. Maybe load_from_std_lib & unsafe_load_from_std_lib? Also any preference on if the first should error if debug is in the list or just ignore it?
There was a problem hiding this comment.
Yeah you're right, I see your point on load_from_std_lib, that's fine.
The safe version should panic I think if it's asked to load the debug library (that's what new does).
There was a problem hiding this comment.
Ah, should have looked at that. 👍
Changed to load_from_std_lib and unsafe_load_from_std_lib. (Also squashed the fixups.)
azdle
force-pushed
the
load_from_std_lib
branch
from
19a663c to
c4efdf2
Compare
This function allows loading of any portion of the standard libraries after initial state creation, except debug for unsafety reasons. Also added is `unsafe_load_from_std_lib` which *does* also allow loading the debug library. Specifically, this is filling a need to load the debug library after an error is encountered so that a traceback can be generated without risking exposing the debug library anywhere else in the code.
azdle
force-pushed
the
load_from_std_lib
branch
from
c4efdf2 to
7059070
Compare
|
Had to force-push again because I forgot to |
|
Awesome work, thank you very much! |
|
Thank *you* for this wonderful library!
…On Thu, Aug 1, 2019, at 13:42, kyren wrote:
Awesome work, thank you very much!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#136>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACADYXDMMSE7EZ2NNQ5BWLQCMU7LANCNFSM4HZMUKBA>.
|
This function allows loading of any portion of the standard libraries
after initial state creation.
Specifically, this is filling a need to load the debug library after an
error is encountered so that a traceback can be generated without
risking exposing the debug library anywhere else in the code.