Skip to content

Add spinner example #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add spinner example #412

wants to merge 1 commit into from

Conversation

FDiskas
Copy link

@FDiskas FDiskas commented Apr 20, 2020

Overview

In some versions of community date picker the spinner mode was not working. So I added more examples to check if everything is working as aspected

react-native-datetimepicker/datetimepicker#118

@FDiskas
Copy link
Author

FDiskas commented Apr 20, 2020

Also removed yarn lock - because it locks @react-native-community/datetimepicker version. And in mane package @react-native-community/datetimepicker is peer dep. So example should always use latest version

@mmazzarolo
Copy link
Owner

@FDiskas , thanks for the PR. I updated the @react-native-community/datetimepicker version in the example's package.
I'm not merging this PR though because I'd like to keep the example code simple, and the issue you had was related to the community version being outdated.
Thanks for reporting !

@mmazzarolo mmazzarolo closed this Apr 26, 2020
@FDiskas FDiskas deleted the add-more-examples branch April 26, 2020 11:40
@FDiskas
Copy link
Author

FDiskas commented Apr 26, 2020

Any way i thought that there should be as an example

@mmazzarolo
Copy link
Owner

Any way i thought that there should be as an example

I'm avoiding it because it's an example of something that would be subject to changes that are not in our control (community picker changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants