Skip to content

Count malloc size in pages #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qinsoon opened this issue Aug 24, 2022 · 0 comments
Open

Count malloc size in pages #649

qinsoon opened this issue Aug 24, 2022 · 0 comments
Labels
A-interface Area: Interface/API A-policy Area: Policy C-bug Category: Bug P-low Priority: Low. A low-priority issue won't be scheduled and assigned. Any help is welcome.

Comments

@qinsoon
Copy link
Member

qinsoon commented Aug 24, 2022

We should count malloc size by pages in malloc mark sweep. And when we provide counted malloc, we should also count in pages (which means we will need to maintain some metadata to track which page is used in MMTk for those malloc results).

We probably will share some code between those two. #572 was trying to turn the current malloc marksweep space to a manual malloc space. We may not directly use code from the pull request.

@qinsoon qinsoon added C-bug Category: Bug A-interface Area: Interface/API A-policy Area: Policy labels Aug 24, 2022
qinsoon added a commit that referenced this issue Nov 7, 2022
This PR changes how our malloc mark sweep accounts for memory. We are currently accounting bytes used, which is wrong. This PR changes that to page-based accounting. This PR addresses the issue #649 for malloc mark sweep (further work is still needed for the issue for our malloc API).

* by default, we do not use bulk XOR for malloc mark sweep (which is known to have issues with page accounting)
* Allow different malloc page size for library malloc
@udesou udesou added the P-low Priority: Low. A low-priority issue won't be scheduled and assigned. Any help is welcome. label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interface Area: Interface/API A-policy Area: Policy C-bug Category: Bug P-low Priority: Low. A low-priority issue won't be scheduled and assigned. Any help is welcome.
Projects
None yet
Development

No branches or pull requests

2 participants