Remove print!/println! code from mmtk-core #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
requested changes
Aug 31, 2022
src/policy/space.rs
Outdated
| @@ -608,28 +608,34 @@ pub trait Space<VM: VMBinding>: 'static + SFT + Sync + Downcast { | |||
| panic!("A copying space should override this method") | |||
| } | |||
|
|
|||
| fn print_vm_map(&self) { | |||
| fn print_vm_map(&self) -> String { | |||
There was a problem hiding this comment.
A more general solution is to write to a &mut impl Write. It can write to a string in this way, and also a file, too, if the user desires. The Write trait still allows us to use the write! or writeln! macros for formatting, like the print! macro in the old code.
Example:
use std::fmt::{Error, Write};
fn print_something(out: &mut impl Write) -> Result<(), Error> {
writeln!(out, "Hello world!")?;
writeln!(out, "Number: {}", 42)?;
Ok(())
}
fn main() {
let mut s = String::new();
print_something(&mut s).unwrap();
println!("{}", s);
}There was a problem hiding this comment.
Good idea. I changed the method. However, as we cannot have methods with generic type parameters (including impl T) in a object-safe trait (Space), I moved the method outside the trait.
wks
added a commit
to mmtk/ruby
that referenced
this pull request
Aug 31, 2022
This reverts commit de7fb26. The upstream fixed the printing issue in: mmtk/mmtk-core#655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
print!andprintln!from our code base.print!/println!are replaced with logging lines, oreprint!/eprintln!if we really need to report errors. This closes #654.