Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of private reflection from tests #48

Open
eiriktsarpalis opened this issue Mar 21, 2025 · 0 comments
Open

Remove use of private reflection from tests #48

eiriktsarpalis opened this issue Mar 21, 2025 · 0 comments

Comments

@eiriktsarpalis
Copy link
Contributor

Added private reflection as a stopgap so that we can disable InternalsVisibleTo. We should eventually remove all use of private reflection in tests.

Originally posted by @stephentoub in #46 (comment)
jaredpar added a commit to jaredpar/csharp-sdk that referenced this issue Mar 21, 2025
@jaredpar
Remove reflection from Connect test
b821124 
This removes the reflection from the double connection test and replaces it with a
`MockHttpHandler` to let the connection actually succeed and then test the
redundant `ConnectAsync` call.

partial fix for modelcontextprotocol#48
@jaredpar jaredpar mentioned this issue Mar 21, 2025
Merged
9 tasks
eiriktsarpalis pushed a commit that referenced this issue Mar 22, 2025
@jaredpar @stephentoub
Remove reflection from Connect test (#57)
d18da9a 
* Remove reflection from Connect test

This removes the reflection from the double connection test and replaces it with a
`MockHttpHandler` to let the connection actually succeed and then test the
redundant `ConnectAsync` call.

partial fix for #48

* remove unneeded using

---------

Co-authored-by: Stephen Toub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eiriktsarpalis