Add [McpServerPrompt] support #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
mcpserverprompt
branch
2 times, most recently
from
6eaa071 to
9f03dcc
Compare
|
This is ready for review. |
stephentoub
commented
Mar 28, 2025
PederHP
reviewed
Mar 28, 2025
|
Maybe add WeatherPrompts to the server QuickStart? With example prompts for exercising each tool? This shows both the Prompt feature and helps guide users to using the server correctly (no need to figure out the correct prompt to make the model call the tool). |
stephentoub
force-pushed
the
mcpserverprompt
branch
3 times, most recently
from
caa949a to
d8142fb
Compare
aaronpowell
added a commit
to aaronpowell/modelcontextprotocol-csharp-sdk
that referenced
this pull request
Mar 31, 2025
It's not the best handler, but modelcontextprotocol#126 will make this easier
stephentoub
force-pushed
the
mcpserverprompt
branch
from
d8142fb to
eb3f484
Compare
eiriktsarpalis
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the first commit; that's just #124, which this builds on top of.
I also still need to add tests. I could also use some help on a better word than "Items" when talking about the group of things that is tools, prompts, resources, etc.
This adds support for declaratively and programmatically created prompts, e.g. an [McpServerPrompt] attribute to tag functions that should be used as prompts, a set of McpServerPrompt.Create for programmatically created prompt instances, etc.
Closes #70