-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TcpServerTransport
#197
Added TcpServerTransport
#197
Conversation
I am still going to implement more tests for TcpServerTransport and to properly test it in Unity Editor with Claude Desktop. Please hold... |
Really cool to see that particular use case (as a former game dev and game engine dev). Have you considered submitting this as new transport in the spec itself? Custom transports are allowed (and even encouraged I believe?) spec wise, but making sure this doesn't end up different than a future official TCP spec might be good. Or at least getting some input from maintainers on your design. |
Thank you for your contribution @IvanMurzak! Even though we love to see alternative transports being implemented on top of the SDK, unfortunately transports that are not part of the MCP specification are outside the scope of the SDK itself. My recommendation would be to try to create an extension library that builds on top of the SDK. And if per @PederHP's recommendation you are able to get this ratified by the MCP steering committee, then we will absolutely be bringing it into the fold! |
Closing per the above comments. But much appreciated on your interest in contributing to the project, @IvanMurzak! |
Thanks. I was going into a wrong direction... Got confused with implementation of MCP. Thought TCP is a good transport protocol to communicate between Unity and MCP Server. And that is right, just the Seems like I am free to implement TCP communication with any other software on my own without clear standards or limits from the SDK. So yeah, this PR doesn't have much sense. |
TcpServerTransport
.WithTcpServerTransport()
for building MCP Server with TCP supportWithTcpServerTransport
functionMotivation and Context
How Has This Been Tested?
I added tests to cover TCP Protocol. All of them passed.
Breaking Changes
Types of changes
Checklist
Additional context