Disable response buffering for SSE responses #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
changed the title
stephentoub
reviewed
Apr 4, 2025
src/ModelContextProtocol.AspNetCore/McpEndpointRouteBuilderExtensions.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same thing SignalR's ServerSentEventsServerTransport and Blazor's RazorComponentEndpointInvoker does. We didn't catch this before because we test using Kestrel which does not buffer by default.
It's possible to either mock the IHttpResponseBodyFeature or use IIS in integration tests to fully test this fix, but I don't think it's worth the effort right now as I work on other parts of HTTP streaming. I did add test verifying we send the expected headers though.