Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Capability #53

Merged
merged 6 commits into from
Mar 21, 2025

Conversation

PederHP
Copy link
Collaborator

@PederHP PederHP commented Mar 21, 2025

Motivation and Context

Added Logging Capability (server and client)

How Has This Been Tested?

New integration tests

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

This is just the raw handlers and notification params objects, with tests. A future change should make it easy to integrate with .NET Logging abstraction on either side. But this is the foundation to enable that.

Copy link
Contributor

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can follow-up after this to integrate with Microsoft.Extensions.Logging.Abstractions, layering an ILogger on top on the server.

@stephentoub stephentoub merged commit 10c712a into modelcontextprotocol:main Mar 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants