Skip to content

Add MCP proxy address config support, better error messages, redesigned Config panel #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pulkitsharma07
Copy link
Contributor

@pulkitsharma07 pulkitsharma07 commented Apr 1, 2025

1. Add support to connect to MCP Inspector Proxy running on a different address (host/port).

Screenshot 2025-04-01 at 7 30 30 PM

2. Better error messaging in case MCP Server is down OR MCP Inspector Proxy is down.

Screenshot 2025-04-01 at 7 28 45 PM
Screenshot 2025-04-01 at 7 29 03 PM

3. Redesigned configuration panel to show key names (which will help in moving to a centralised config file in the future), with tooltips

Screen.Recording.2025-04-01.at.7.31.14.PM.mov

Motivation and Context

How Has This Been Tested?

Tested locally with remote MCP + running MCP proxy on different port

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pulkitsharma07
Copy link
Contributor Author

cc @cliffhall @olaservo for review

cliffhall
cliffhall previously approved these changes Apr 1, 2025
Copy link
Contributor

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

  • Reviewed the PR and tested locally with valid and invalid proxy address.
Screenshot 2025-04-01 at 12 53 10 PM Screenshot 2025-04-01 at 12 53 20 PM
  • Tooltips also work (proxy one is a little long, but ok).
Screenshot 2025-04-01 at 12 57 48 PM Screenshot 2025-04-01 at 12 57 57 PM

@cliffhall cliffhall requested a review from olaservo April 1, 2025 17:00
@cliffhall
Copy link
Contributor

Reaching out to @olaservo to weigh in on the implementation and who might also be able to test on Windows.

@cliffhall
Copy link
Contributor

@pulkitsharma07 looks like there are some conflicts to resolve.

@cliffhall cliffhall added enhancement New feature or request waiting on submitter Waiting for the submitter to provide more info labels Apr 1, 2025
@pulkitsharma07
Copy link
Contributor Author

Resolved

@cliffhall
Copy link
Contributor

@pulkitsharma07 yet again more conflicts to resolve.

@pulkitsharma07
Copy link
Contributor Author

@cliffhall done

Copy link
Contributor

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again locally. LGTM! 👍

@cliffhall cliffhall merged commit ce1a9d3 into modelcontextprotocol:main Apr 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting on submitter Waiting for the submitter to provide more info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants