Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mcp): Custom context paths in HTTP Servlet SSE server transport #112

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

tzolov
Copy link
Contributor

@tzolov tzolov commented Apr 6, 2025

Enhance HttpServletSseServerTransportProvider to support deployment under non-root context paths by:

  • Adding baseUrl field and DEFAULT_BASE_URL constant
  • Creating new constructor that accepts a baseUrl parameter
  • Extending Builder with baseUrl configuration method
  • Prepending baseUrl to message endpoint in SSE events
  • Add HttpServletSseServerCustomContextPathTests to verify custom context path functionality
  • Extract common Tomcat server setup code to TomcatTestUtil for test reuse

Related to #79

…erver transport

Enhance HttpServletSseServerTransportProvider to support deployment under non-root context paths by:

- Adding baseUrl field and DEFAULT_BASE_URL constant
- Creating new constructor that accepts a baseUrl parameter
- Extending Builder with baseUrl configuration method
- Prepending baseUrl to message endpoint in SSE events
- Add HttpServletSseServerCustomContextPathTests to verify custom context path functionality
- Extract common Tomcat server setup code to TomcatTestUtil for test reuse

Related to #79

Signed-off-by: Christian Tzolov <[email protected]>
@tzolov tzolov changed the title feat(mcp): Add support for custom context paths in HTTP Servlet SSE s… feat(mcp): Custom context paths in HTTP Servlet SSE server transport Apr 6, 2025
@tzolov tzolov marked this pull request as ready for review April 6, 2025 16:47
@tzolov tzolov added enhancement New feature or request server labels Apr 6, 2025
@tzolov tzolov added this to the 0.9.0 milestone Apr 6, 2025
@tzolov tzolov merged commit 8fc72ae into main Apr 6, 2025
1 check passed
@tzolov tzolov deleted the add-base-url-servlet-sse branch April 6, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant