Skip to content

Fix typo mistake in comments and method params #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

oleksandr-popov
Copy link
Contributor

After first analyze source code I found some mistake in typo with IDE spellcheck. I just make it after found mistake in interface McpServer

Motivation and Context

Fix typo errors. No imponent on logic

How Has This Been Tested?

No need more tests. Run exists tests.

Breaking Changes

No break changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

I found that in interface MPCServer on line 623 (method tool) in JavaDocs contain @link to not exist ToolRegistration entity.
Understand that it's referrer to SyncToolRegistration and AsyncToolRegistration, but it better to contain link to existing entity in code.

@tzolov
Copy link
Contributor

tzolov commented Mar 27, 2025

Hey @oleksandr-popov
Thank your contribution. As in 0.8.x we made some restructuring some of the classes in your PR doesn't exist anymore.
Let me know if you want to rebase and update this PR. It might easier to start over?

# Conflicts:
#	mcp/src/main/java/io/modelcontextprotocol/client/McpAsyncClient.java
#	mcp/src/main/java/io/modelcontextprotocol/server/McpServer.java
@oleksandr-popov
Copy link
Contributor Author

Hi @tzolov.
I update PR with latest changes and now it just contains only very small (not important) typo.
From new changes I see only that was removed Javadoc's comment for method asyncLoggingNotificationHandler
So now this PR it can be ignored or removed, because it does not contain any real reason, except indicate only small problem in comments.

tzolov pushed a commit that referenced this pull request Apr 6, 2025
@tzolov
Copy link
Contributor

tzolov commented Apr 6, 2025

Thanks @oleksandr-popov
Because of unnecessary merges and conflicts I had to redo the changes but made you the author of the commit. In the future please use 'git pull -r origin main' (e.g. rebase) instead of merging to main.
redone and merged at cd624a7

@tzolov tzolov closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants